librelist archives

« back to archive

[PATCH] Add full screen button for Mac OS X

[PATCH] Add full screen button for Mac OS X

From:
Trevor Jim
Date:
2014-01-24 @ 21:45
---
 content/conkeror.xul | 1 +
 1 file changed, 1 insertion(+)

diff --git a/content/conkeror.xul b/content/conkeror.xul
index 0eb83a6..fe93dd4 100644
--- a/content/conkeror.xul
+++ b/content/conkeror.xul
@@ -17,6 +17,7 @@ COPYING file.
     title="Conkeror"
     id="main-window"
     width="640" height="480"
+    fullscreenbutton="true"
     persist="screenX screenY width height sizemode"
     windowtype="navigator:browser">
 
-- 
1.8.5.1

Re: [conkeror] [PATCH] Add full screen button for Mac OS X

From:
John J. Foerch
Date:
2014-06-08 @ 01:18
On Fri, Jan 24, 2014 at 04:45:11PM -0500, Trevor Jim wrote:
> 
> ---
>  content/conkeror.xul | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/content/conkeror.xul b/content/conkeror.xul
> index 0eb83a6..fe93dd4 100644
> --- a/content/conkeror.xul
> +++ b/content/conkeror.xul
> @@ -17,6 +17,7 @@ COPYING file.
>      title="Conkeror"
>      id="main-window"
>      width="640" height="480"
> +    fullscreenbutton="true"
>      persist="screenX screenY width height sizemode"
>      windowtype="navigator:browser">
>  
> -- 
> 1.8.5.1
> 

Does this have any effect on other platforms?

-- 
John Foerch

Re: [conkeror] [PATCH] Add full screen button for Mac OS X

From:
Trevor Jim
Date:
2014-06-09 @ 01:15
I’m not able to test on other systems, but the documentation says:

> Set this attribute to true to display a button in the window chrome to 
allow the user to switch the window into full screen mode. Supported on 
Mac OS X 10.7 Lion and later and on Windows. The window receives a 
"fullscreen" event once the change has been made.


https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/fullscreenbutton

I noticed the setting by examining the latest firefox on mac.

Re: [conkeror] [PATCH] Add full screen button for Mac OS X

From:
John J. Foerch
Date:
2014-06-09 @ 03:00
On Sun, Jun 08, 2014 at 09:15:12PM -0400, Trevor Jim wrote:
> I’m not able to test on other systems, but the documentation says:
> 
> > Set this attribute to true to display a button in the window chrome to
allow the user to switch the window into full screen mode. Supported on 
Mac OS X 10.7 Lion and later and on Windows. The window receives a 
"fullscreen" event once the change has been made.
> 
> 
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/fullscreenbutton
> 
> I noticed the setting by examining the latest firefox on mac.
> 

Oh okay, so it is general, not specific to OS X.  Seems like a good thing.
Will merge it soon.

-- 
John Foerch