librelist archives

« back to archive

Fwd: [BrowserQuest] Updated so pvp, database backend saves, target hovering, leveling system is available. Also changed cli for guilds ( /guild invite, /guild create etc) (#44)

Fwd: [BrowserQuest] Updated so pvp, database backend saves, target hovering, leveling system is available. Also changed cli for guilds ( /guild invite, /guild create etc) (#44)

From:
Justin Clift
Date:
2013-06-16 @ 13:22
Hi everyone,

Fredrik Svantes has just submitted a fairly extensive PR, adding 
(mandatory) backend
database support with Redis, as well as a bunch of other stuff.

I'll try it out today.  Anyone else wanting to take a look too? :)

Regards and best wishes,

Justin Clift


Begin forwarded message:
> From: Fredrik Svantes <notifications@github.com>
> Subject: [BrowserQuest] Updated so pvp, database backend saves, target 
hovering, leveling system is available. Also changed cli for guilds ( 
/guild invite, /guild create etc) (#44)
> Date: 16 June 2013 11:47:49 AM GMT+01:00
> To: browserquest/BrowserQuest <BrowserQuest@noreply.github.com>
> Reply-To: browserquest/BrowserQuest 
<reply+i-15603520-f60b65e9df2d4c80cf0d0fea28f71b877e3eb23e-406299@reply.github.com>
> 
> Updated so pvp, database backend saves, target hovering, leveling system
is available. Also changed cli for guilds ( /guild invite, /guild create 
etc)
> 
> You can merge this Pull Request by running
> 
>   git pull https://github.com/speedis/BrowserQuest master
> Or view, comment on, or merge it at:
> 
>   https://github.com/browserquest/BrowserQuest/pull/44
> 
> Commit Summary
> 
> Updated so pvp, database backend saves, target hovering, leveling system
is available. Also changed cli for guilds ( /guild invite, /guild create 
etc)
> File Changes
> 
> M README.md (38)
> M client/css/main.css (154)
> M client/index.html (114)
> A client/js/README.md (139)
> M client/js/app.js (81)
> M client/js/character.js (25)
> M client/js/game.js (171)
> M client/js/gameclient.js (84)
> M client/js/infomanager.js (22)
> M client/js/main.js (184)
> M client/js/player.js (43)
> M client/js/renderer.js (18)
> M package.json (1)
> A server/js/README.md (78)
> A server/js/databasehandler.js (559)
> M server/js/format.js (5)
> M server/js/main.js (8)
> M server/js/map.js (23)
> M server/js/message.js (27)
> M server/js/mob.js (76)
> M server/js/player.js (404)
> M server/js/properties.js (3)
> M server/js/utils.js (11)
> M server/js/worldserver.js (63)
> M shared/js/gametypes.js (109)
> Patch Links:
> 
> https://github.com/browserquest/BrowserQuest/pull/44.patch
> https://github.com/browserquest/BrowserQuest/pull/44.diff

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift

Re: [browserquest] Fwd: [BrowserQuest] Updated so pvp, database backend saves, target hovering, leveling system is available. Also changed cli for guilds ( /guild invite, /guild create etc) (#44)

From:
Mathieu Loiseau
Date:
2013-06-16 @ 13:32
I've got a busy schedule the next few days, but I'll try to have a look 
at it from wendnesday on. Many functionnalities interest me. Might take 
a little while to test all that extensively...
Kind regards,
Mathieu

Le 16/06/2013 15:22, Justin Clift a écrit :
> Hi everyone,
>
> Fredrik Svantes has just submitted a fairly extensive PR, adding 
> (mandatory) backend
> database support with Redis, as well as a bunch of other stuff.
>
> I'll try it out today.  Anyone else wanting to take a look too? :)
>
> Regards and best wishes,
>
> Justin Clift
>
>
> Begin forwarded message:
>> *From: *Fredrik Svantes <notifications@github.com 
>> <mailto:notifications@github.com>>
>> *Subject: **[BrowserQuest] Updated so pvp, database backend saves, 
>> target hovering, leveling system is available. Also changed cli for 
>> guilds ( /guild invite, /guild create etc) (#44)*
>> *Date: *16 June 2013 11:47:49 AM GMT+01:00
>> *To: *browserquest/BrowserQuest <BrowserQuest@noreply.github.com 
>> <mailto:BrowserQuest@%0A%20noreply.%0A%20github.com>>
>> *Reply-To: *browserquest/BrowserQuest 
>> 
<reply+i-15603520-f60b65e9df2d4c80cf0d0fea28f71b877e3eb23e-406299@reply.github.com

>> 
<mailto:reply+i-15603520-f60b65e9df2d4c80cf0d0fea28f71b877e3eb23e-406299@reply.github.com>>
>>
>> Updated so pvp, database backend saves, target hovering, leveling 
>> system is available. Also changed cli for guilds ( /guild invite, 
>> /guild create etc)
>>
>> ------------------------------------------------------------------------
>>
>>
>>         You can merge this Pull Request by running
>>
>>    git pullhttps://github.com/speedis/BrowserQuest  master
>>
>> Or view, comment on, or merge it at:
>>
>> https://github.com/browserquest/BrowserQuest/pull/44
>>
>>
>>         Commit Summary
>>
>>   * Updated so pvp, database backend saves, target hovering, leveling
>>     system is available. Also changed cli for guilds ( /guild invite,
>>     /guild create etc)
>>
>>
>>         File Changes
>>
>>   * *M* README.md
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-0>
>>     (38)
>>   * *M* client/css/main.css
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-1>
>>     (154)
>>   * *M* client/index.html
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-2>
>>     (114)
>>   * *A* client/js/README.md
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-3>
>>     (139)
>>   * *M* client/js/app.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-4>
>>     (81)
>>   * *M* client/js/character.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-5>
>>     (25)
>>   * *M* client/js/game.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-6>
>>     (171)
>>   * *M* client/js/gameclient.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-7>
>>     (84)
>>   * *M* client/js/infomanager.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-8>
>>     (22)
>>   * *M* client/js/main.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-9>
>>     (184)
>>   * *M* client/js/player.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-10>
>>     (43)
>>   * *M* client/js/renderer.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-11>
>>     (18)
>>   * *M* package.json
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-12>
>>     (1)
>>   * *A* server/js/README.md
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-13>
>>     (78)
>>   * *A* server/js/databasehandler.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-14>
>>     (559)
>>   * *M* server/js/format.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-15>
>>     (5)
>>   * *M* server/js/main.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-16>
>>     (8)
>>   * *M* server/js/map.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-17>
>>     (23)
>>   * *M* server/js/message.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-18>
>>     (27)
>>   * *M* server/js/mob.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-19>
>>     (76)
>>   * *M* server/js/player.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-20>
>>     (404)
>>   * *M* server/js/properties.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-21>
>>     (3)
>>   * *M* server/js/utils.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-22>
>>     (11)
>>   * *M* server/js/worldserver.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-23>
>>     (63)
>>   * *M* shared/js/gametypes.js
>>     <https://github.com/browserquest/BrowserQuest/pull/44/files#diff-24>
>>     (109)
>>
>>
>>         Patch Links:
>>
>>   * https://github.com/browserquest/BrowserQuest/pull/44.patch
>>   * https://github.com/browserquest/BrowserQuest/pull/44.diff
>>
>
> --
> Open Source and Standards @ Red Hat
>
> twitter.com/realjustinclift <http://twitter.com/realjustinclift>
>


-- 
Mathieu Loiseau (LIRIS -- équipe SILEX)
Bâtiment Blaise Pascal --- INSA de Lyon
20, av. Albert Einstein
69100 Villeurbanne
http://www.lezinter.net/~lzbk

Re: [browserquest] [BrowserQuest] Updated so pvp, database backend saves, target hovering, leveling system is available. Also changed cli for guilds ( /guild invite, /guild create etc) (#44)

From:
Justin Clift
Date:
2013-06-16 @ 18:23
I took it for a fairly decent test run, completing a new character through to
nuking the boss and doing all of the quests (except the ninja looting one).

The code didn't fall over anywhere, and some of the pieces are a definite
improvement (hover window showing enemy stats, main character now has xp +
levels).  The Redis functionality was easy to set up and "just worked",
which is also good.

Didn't try extensively to bust it, but on the whole it seems ok from an
"end user" perspective.  I've merged the code for now.  We can fix any bugs
that turn up as PR's. :)

Regards and best wishes,

Justin Clift


On 16/06/2013, at 2:32 PM, Mathieu Loiseau wrote:
> I've got a busy schedule the next few days, but I'll try to have a look 
at it from wendnesday on. Many functionnalities interest me. Might take a 
little while to test all that extensively…
> Kind regards,
> Mathieu
> 
> Le 16/06/2013 15:22, Justin Clift a écrit :
>> Hi everyone,
>> 
>> Fredrik Svantes has just submitted a fairly extensive PR, adding 
(mandatory) backend
>> database support with Redis, as well as a bunch of other stuff.
>> 
>> I'll try it out today.  Anyone else wanting to take a look too? :)
>> 
>> Regards and best wishes,
>> 
>> Justin Clift

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift