librelist archives

« back to archive

Keyboard Movement Changes

Keyboard Movement Changes

From:
Jason Culwell
Date:
2013-02-01 @ 13:48
I made some changes to fix and smooth out keyboard movement.  Also
discovered and fixed a rare bug, which became especially prevalent with my
recent changes to keyboard movement.

The changes/commits are available on the repository that I forked at
https://github.com/Mawgamoth/BrowserQuest, if anyone would like to check
them out or review them.  Perhaps they can be merged into the main
BrowserQuest repository?

Also, not sure if I should be communicating here, or via the github
repository.

Let me know what you think!

Re: [browserquest] Keyboard Movement Changes

From:
Justin Clift
Date:
2013-02-01 @ 16:30
On 01/02/2013, at 1:48 PM, Jason Culwell wrote:
> I made some changes to fix and smooth out keyboard movement.  Also 
discovered and fixed a rare bug, which became especially prevalent with my
recent changes to keyboard movement.  
> 
> The changes/commits are available on the repository that I forked at 
https://github.com/Mawgamoth/BrowserQuest, if anyone would like to check 
them out or review them.  Perhaps they can be merged into the main 
BrowserQuest repository?

Chuck them in a pull request, which makes it easy to review them. :)


> Also, not sure if I should be communicating here, or via the github repository.

Either way kind of works. :)

General rule of thumb is to discuss stuff here if you want multiple people to
have thoughts/opinions on something, or are asking about overall project
affecting stuff.

Discussing stuff in GH issues and pull requests is a bit more transactional,
and generally focuses on specific items, but has the advantage of being
trackable.  ie people can see something being worked upon, progress being
made, etc.

+ Justin

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org

Re: [browserquest] Keyboard Movement Changes

From:
Justin Clift
Date:
2013-02-03 @ 13:03
On 01/02/2013, at 1:48 PM, Jason Culwell wrote:
> I made some changes to fix and smooth out keyboard movement.  Also 
discovered and fixed a rare bug, which became especially prevalent with my
recent changes to keyboard movement.  
> 
> The changes/commits are available on the repository that I forked at 
https://github.com/Mawgamoth/BrowserQuest, if anyone would like to check 
them out or review them.  Perhaps they can be merged into the main 
BrowserQuest repository?
> 
> Also, not sure if I should be communicating here, or via the github repository.
> 
> Let me know what you think!

Excellent Jason, thank you. :)

Merged your pull request after trying out the keyboard navigation
for a while, plus added you to the credits in the README file. :>

One small downside of the patch did show up.  It's now harder
to talk to NPC's and get just one line of dialog from them at
a time.  Not sure why, perhaps a timing thing?  Anyway, it wasn't
a big enough problem to delay merging the patch. :)

Regards and best wishes,

Justin Clift

--
Aeolus Cloud Evangelist
http://www.aeolusproject.org

Re: [browserquest] Keyboard Movement Changes

From:
Jason Culwell
Date:
2013-02-04 @ 03:34
Thanks, its very much appreciated! :D

I fixed the issue with the NPCs.  It was cycling through the NPC's messages
at an extreme rate; now they will only spit out one message per "keypress".
 A bit more testing and I will commit and issue pull request.


On Sun, Feb 3, 2013 at 7:03 AM, Justin Clift <jclift@redhat.com> wrote:

> On 01/02/2013, at 1:48 PM, Jason Culwell wrote:
> > I made some changes to fix and smooth out keyboard movement.  Also
> discovered and fixed a rare bug, which became especially prevalent with my
> recent changes to keyboard movement.
> >
> > The changes/commits are available on the repository that I forked at
> https://github.com/Mawgamoth/BrowserQuest, if anyone would like to check
> them out or review them.  Perhaps they can be merged into the main
> BrowserQuest repository?
> >
> > Also, not sure if I should be communicating here, or via the github
> repository.
> >
> > Let me know what you think!
>
> Excellent Jason, thank you. :)
>
> Merged your pull request after trying out the keyboard navigation
> for a while, plus added you to the credits in the README file. :>
>
> One small downside of the patch did show up.  It's now harder
> to talk to NPC's and get just one line of dialog from them at
> a time.  Not sure why, perhaps a timing thing?  Anyway, it wasn't
> a big enough problem to delay merging the patch. :)
>
> Regards and best wishes,
>
> Justin Clift
>
> --
> Aeolus Cloud Evangelist
> http://www.aeolusproject.org
>
>