librelist archives

« back to archive

Removing usage of shift when getting method arguments

Removing usage of shift when getting method arguments

From:
Athos Ribeiro
Date:
2013-05-09 @ 03:32
We just removed most of the shifts getting method arguments, though we were
not sure if we should also include self reference to the methods which did
not do it, so we didn't.

Sending a pull request for review.

Re: [analizo] Removing usage of shift when getting method arguments

From:
Antonio Terceiro
Date:
2013-05-09 @ 03:55
On Thu, May 09, 2013 at 12:32:00AM -0300, Athos Ribeiro wrote:
> We just removed most of the shifts getting method arguments, though we were
> not sure if we should also include self reference to the methods which did
> not do it, so we didn't.
> 
> Sending a pull request for review.

Hi Athos and team, thanks for working on this!

Note that it's redundant to post on the list telling that you sent a
pull request, because when you create the pull request it already sends
a notification by email. :-)

-- 
Antonio Terceiro <terceiro@softwarelivre.org>
http://softwarelivre.org/terceiro

Re: [analizo] Removing usage of shift when getting method arguments

From:
Paulo Meirelles
Date:
2013-05-09 @ 04:46
2013/5/9 Antonio Terceiro <terceiro@softwarelivre.org>

> On Thu, May 09, 2013 at 12:32:00AM -0300, Athos Ribeiro wrote:
> > We just removed most of the shifts getting method arguments, though we
> were
> > not sure if we should also include self reference to the methods which
> did
> > not do it, so we didn't.
> >
> > Sending a pull request for review.
>
> Hi Athos and team, thanks for working on this!
>
> Note that it's redundant to post on the list telling that you sent a
> pull request, because when you create the pull request it already sends
> a notification by email. :-)
>

An email just for you ;). I've asked to Athos to send by email too, so that
all team (and me) can see and discuss about our issues.

Any suggestion?

-- 
Paulo Meirelles
FGA-UnB (http://fga.unb.br)
CCSL-IME/USP (http://ccsl.ime.usp.br)

Re: [analizo] Removing usage of shift when getting method arguments

From:
Antonio Terceiro
Date:
2013-05-09 @ 13:30
On Thu, May 09, 2013 at 01:46:54AM -0300, Paulo Meirelles wrote:
> 2013/5/9 Antonio Terceiro <terceiro@softwarelivre.org>
> 
> > On Thu, May 09, 2013 at 12:32:00AM -0300, Athos Ribeiro wrote:
> > > We just removed most of the shifts getting method arguments, though we
> > were
> > > not sure if we should also include self reference to the methods which
> > did
> > > not do it, so we didn't.
> > >
> > > Sending a pull request for review.
> >
> > Hi Athos and team, thanks for working on this!
> >
> > Note that it's redundant to post on the list telling that you sent a
> > pull request, because when you create the pull request it already sends
> > a notification by email. :-)
> >
> 
> An email just for you ;). I've asked to Athos to send by email too, so that
> all team (and me) can see and discuss about our issues.
> 
> Any suggestion?

https://help.github.com/articles/watching-repositories

-- 
Antonio Terceiro <terceiro@softwarelivre.org>
http://softwarelivre.org/terceiro

Re: [analizo] Removing usage of shift when getting method arguments

From:
Paulo Meirelles
Date:
2013-05-09 @ 18:44
2013/5/9 Antonio Terceiro <terceiro@softwarelivre.org>

> On Thu, May 09, 2013 at 01:46:54AM -0300, Paulo Meirelles wrote:
> > 2013/5/9 Antonio Terceiro <terceiro@softwarelivre.org>
> >
> > > On Thu, May 09, 2013 at 12:32:00AM -0300, Athos Ribeiro wrote:
> > > > We just removed most of the shifts getting method arguments, though
> we
> > > were
> > > > not sure if we should also include self reference to the methods
> which
> > > did
> > > > not do it, so we didn't.
> > > >
> > > > Sending a pull request for review.
> > >
> > > Hi Athos and team, thanks for working on this!
> > >
> > > Note that it's redundant to post on the list telling that you sent a
> > > pull request, because when you create the pull request it already sends
> > > a notification by email. :-)
> > >
> >
> > An email just for you ;). I've asked to Athos to send by email too, so
> that
> > all team (and me) can see and discuss about our issues.
> >
> > Any suggestion?
>
> https://help.github.com/articles/watching-repositories
>
>
Sorry ;)

-- 
Paulo Meirelles
FGA-UnB (http://fga.unb.br)
CCSL-IME/USP (http://ccsl.ime.usp.br)

Re: [analizo] Removing usage of shift when getting method arguments

From:
Antonio Terceiro
Date:
2013-05-10 @ 04:33
On Thu, May 09, 2013 at 03:44:30PM -0300, Paulo Meirelles wrote:
> > https://help.github.com/articles/watching-repositories
> >
> >
> Sorry ;)

Nothing to be sorry for.

-- 
Antonio Terceiro <terceiro@softwarelivre.org>
http://softwarelivre.org/terceiro